museum-digital/musdb-md-xm-xsls
34
0
Fork 1
Code Issues 5 Pull Requests Projects Releases Wiki Activity

minor fix of xsi:schemaLocation #2

Merged
jrenslin merged 3 commits from awinkler/musdb-md-xm-xsls:master into master 2023-02-28 18:49:47 +01:00
Conversation 0 Commits 3 Files Changed 3 +1966 -1966
awinkler commented 2023-02-28 17:39:21 +01:00
Member
Copy Link

There seems to be a minor issue in the lido:lidoWrap attributes linking the xml-schemas. Right now, a xmlns:schemaLocation namespace is created (which I think is not correct) and no schema is linked to the gml URI.
This PL rearranges the attributes a bit so that it should work alright.

I'm not sure what's the problem with the diff in a32d94a2f5 . The only change I've made concerns l. 7.

There seems to be a minor issue in the `lido:lidoWrap` attributes linking the xml-schemas. Right now, a `xmlns:schemaLocation` namespace is created (which I think is not correct) and no schema is linked to the `gml` URI. This PL rearranges the attributes a bit so that it should work alright. I'm not sure what's the problem with the diff in a32d94a2f5749a4bef8de693a525bb51ab1bf523 . The only change I've made concerns l. 7.
awinkler added 3 commits 2023-02-28 17:39:21 +01:00 
Currently, the export generates (erroneously, I guess) an `xmlns:schemaLocation` namespace and consequently doesn't link the gml schema properly. I've changed the attributes in `lido:lidoWrap` to fix this issue.

Signed-off-by: Alexander Winkler <winkler@zib.de>
Signed-off-by: Alexander Winkler <winkler@zib.de>
Signed-off-by: Alexander Winkler <winkler@zib.de>
jrenslin approved these changes 2023-02-28 18:49:38 +01:00
jrenslin left a comment
Owner
Copy Link

Looks very good.

Looks very good.
jrenslin merged commit 0ea0d77192 into master 2023-02-28 18:49:47 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
jrenslin
Labels
Clear labels   
kind/breaking

Critical issue that breaks a page

  
kind/bug

Something is not working

  
kind/docs

This concerns the documentation

  
kind/enhancement

Improvements on existing features

  
kind/feature

New features

  
kind/lint

Code linting error

  
kind/proposal

Suggestion or proposal

  
kind/question

A question

  
kind/refactor

Refactoring code

  
kind/security

Security issue

  
kind/testing

Concerns the test setup

  
kind/translation

Concerns multilinguality

  
kind/ui

Concerns the user interface

  
priority/critical

Critical issue, highest priority

  
priority/high

High priority issue

  
priority/low

Low priority issue

  
priority/medium

Medium priority issue

  
reviewed/duplicate

This is a duplicate

  
reviewed/invalid

This is an invalid issue

  
reviewed/wontfix

This is issue will not be fixed

  
status/done

This issue has been fixed

  
status/needs-feedback

This issue needs feedback

  
kind/breaking

Critical issue that breaks a page

  
kind/bug

Something is not working

  
kind/docs

This concerns the documentation

  
kind/enhancement

Improvements on existing features

  
kind/feature

New features

  
kind/lint

Code linting error

  
kind/proposal

Suggestion or proposal

  
kind/question

A question

  
kind/refactor

Refactoring code

  
kind/security

Security issue

  
kind/testing

Concerns the test setup

  
kind/translation

Concerns multilinguality

  
kind/ui

Concerns the user interface

  
priority/critical

Critical issue, highest priority

  
priority/high

High priority issue

  
priority/low

Low priority issue

  
priority/medium

Medium priority issue

  
reviewed/duplicate

This is a duplicate

  
reviewed/invalid

This is an invalid issue

  
reviewed/wontfix

This is issue will not be fixed

  
status/done

This issue has been fixed

  
status/needs-feedback

This issue needs feedback

No Label
kind/breaking
kind/bug
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/done
status/needs-feedback
kind/breaking
kind/bug
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/done
status/needs-feedback
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: museum-digital/musdb-md-xm-xsls#2
No description provided.
Delete Branch "awinkler/musdb-md-xm-xsls:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?