museum-digital/MDNodaHelpers
33
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

Use ON DUPLICATE KEY update instead of checking value existence with a

Browse Source 
separate query
This commit is contained in:
Joshua Ramon Enslin 2021-12-11 01:29:48 +01:00
parent 9471a030d5
commit e00dd08c23
Signed by: jrenslin
GPG Key ID: 46016F84501B70AE
1 changed files with 9 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/NodaWikidataFetcher.php
View File

@ -964,40 +964,15 @@ final class NodaWikidataFetcher {
// Write link to wikipedia to relevant noda DB table
$wikiAlreadyResult = $this->_mysqli_noda->query_by_stmt("SELECT `noda_orte`.`noda_id`
FROM `noda_orte`
WHERE `noda_orte`.`ort_id` = ?
AND `noda_orte`.`noda_source` = 'Wikipedia'", "i", $placeID);
switch ($wikiAlreadyResult->num_rows) {
case 0:
$insertWikiStmt = $this->_mysqli_noda->do_prepare("INSERT INTO `noda_orte`
(`ort_id`, `noda_source`, `noda_nrinsource`, `noda_link`, `noda_erfasst_am`, `noda_erfasst_von`)
VALUES
(?, 'Wikipedia', '', ?, NOW(), ?)");
$insertWikiStmt->bind_param("iss", $placeID, $wikilink[$lang], $erfasst_von);
$insertWikiStmt->execute();
$insertWikiStmt->close();
unset($insertWikiStmt);
break;
case 1:
if ($wikiAlreadyData = $wikiAlreadyResult->fetch_assoc()) {
$wikischon_id = $wikiAlreadyData['noda_id'];
$updateStmt = $this->_mysqli_noda->do_prepare("UPDATE `noda_orte` SET `noda_link` = ? WHERE `noda_id` = ?");
$updateStmt->bind_param("si", $wikilink[$lang], $wikischon_id);
$updateStmt->execute();
$updateStmt->close();
unset($updateStmt);
}
break;
}
$wikiAlreadyResult->close();
unset($wikiAlreadyResult);
$insertWikiStmt = $this->_mysqli_noda->do_prepare("INSERT INTO `noda_orte`
(`ort_id`, `noda_source`, `noda_nrinsource`, `noda_link`, `noda_erfasst_am`, `noda_erfasst_von`)
VALUES
(?, 'Wikipedia', '', ?, NOW(), ?)
ON DUPLICATE KEY UPDATE `noda_link` = ?");
$insertWikiStmt->bind_param("isss", $placeID, $wikilink[$lang], $erfasst_von, $wikilink[$lang]);
$insertWikiStmt->execute();
$insertWikiStmt->close();
unset($insertWikiStmt);
return true;