museum-digital/MDAllowedValueSets
34
0 Fork 2
Code Issues 14 Pull Requests Releases Wiki Activity

Handle extended GND IDs (like 4114170-2 Fenster (Motiv))

Browse Source 
Close #46
This commit is contained in:
jrenslin committed 2025-12-03 14:54:03 +01:00
1 parent 59aba25d0e
commit 3d8dac9910
2 files changed
+7
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/enums/MDNodaRepository.php
+5
View File
@@ -438,6 +438,11 @@ private static function validateGndId(string $id, array $prefixes):string|false
$id = strtr($id, $toRemove);
}
// Handle extended IDs (like "4114170-2 (Fenster (Motiv)")
if (str_contains($id, '(')) {
$id = trim(explode('(', $id)[0]);
}
// There is an issue with this regex
if (preg_match("/^[0-9-X]*$/", $id) === false) {
return false;
tests/MDNodaRepositoryTest.php
+2
View File
@@ -36,6 +36,8 @@ public function testValidIdsValidate():void {
self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("https://explore.gnd.network/gnd/1037602218"));
self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008"));
self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008,"));
self::assertEquals("4114170-2", MDNodaRepository::gnd->validateId("4114170-2"));
self::assertEquals("4114170-2", MDNodaRepository::gnd->validateId("4114170-2 (Fenster (Motiv)"));
self::assertEquals(false, MDNodaRepository::gnd->validateId("fkld;s102423008"));
// NDL (Japan)