museum-digital/MDAllowedValueSets
35
0
Fork 0
Code Issues 12 Pull Requests Releases Wiki Activity

rtrim() commas from noda repository links

Browse Source
This commit is contained in:
Joshua Ramon Enslin
2025-10-17 11:06:25 +02:00
parent ee2e40ad5c
commit 0ac48adc51
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/enums/MDNodaRepository.php
View File

@@ -707,6 +707,8 @@ enum MDNodaRepository implements MDValueEnumInterface, JsonSerializable {
*/ */
public function validateId(string $id):string|false { public function validateId(string $id):string|false {
$id = rtrim($id, " ,\t~-");
return match($this) { return match($this) {
self::allgemein => filter_var($id, FILTER_VALIDATE_URL), self::allgemein => filter_var($id, FILTER_VALIDATE_URL),
self::aat => self::validateNumericId($id, [ self::aat => self::validateNumericId($id, [

1
tests/MDNodaRepositoryTest.php
View File

@@ -35,6 +35,7 @@ final class MDNodaRepositoryTest extends TestCase {
self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("http://d-nb.info/gnd/1037602218")); self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("http://d-nb.info/gnd/1037602218"));
self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("https://explore.gnd.network/gnd/1037602218")); self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("https://explore.gnd.network/gnd/1037602218"));
self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008")); self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008"));
self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008,"));
self::assertEquals(false, MDNodaRepository::gnd->validateId("fkld;s102423008")); self::assertEquals(false, MDNodaRepository::gnd->validateId("fkld;s102423008"));
// NDL (Japan) // NDL (Japan)