From 0ac48adc51f12dc25f9e9b993238d6c3d2e8431c Mon Sep 17 00:00:00 2001 From: Joshua Ramon Enslin Date: Fri, 17 Oct 2025 11:06:25 +0200 Subject: [PATCH] rtrim() commas from noda repository links --- src/enums/MDNodaRepository.php | 2 ++ tests/MDNodaRepositoryTest.php | 1 + 2 files changed, 3 insertions(+) diff --git a/src/enums/MDNodaRepository.php b/src/enums/MDNodaRepository.php index 81de062..0e84fa0 100644 --- a/src/enums/MDNodaRepository.php +++ b/src/enums/MDNodaRepository.php @@ -707,6 +707,8 @@ enum MDNodaRepository implements MDValueEnumInterface, JsonSerializable { */ public function validateId(string $id):string|false { + $id = rtrim($id, " ,\t~-"); + return match($this) { self::allgemein => filter_var($id, FILTER_VALIDATE_URL), self::aat => self::validateNumericId($id, [ diff --git a/tests/MDNodaRepositoryTest.php b/tests/MDNodaRepositoryTest.php index 06e93fb..5a72446 100644 --- a/tests/MDNodaRepositoryTest.php +++ b/tests/MDNodaRepositoryTest.php @@ -35,6 +35,7 @@ final class MDNodaRepositoryTest extends TestCase { self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("http://d-nb.info/gnd/1037602218")); self::assertEquals("1037602218", MDNodaRepository::gnd->validateId("https://explore.gnd.network/gnd/1037602218")); self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008")); + self::assertEquals("102423008", MDNodaRepository::gnd->validateId("102423008,")); self::assertEquals(false, MDNodaRepository::gnd->validateId("fkld;s102423008")); // NDL (Japan)