Check if title ends with full stop #3

New Issue

awinkler · 2023-04-27T12:20:13+02:00

awinkler commented

2023-04-27 12:20:13 +02:00

Currently, if a title ends with a full stop, the reference shown in the literature sections features two full stops in a row, which is typographically awkward. I suggest adding a test to the xsl that checks if the titles ends in ".". If this is the case, skip the "." between title and place of publication.

Example: https://berlin.museum-digital.de/object/113761

Currently, if a title ends with a full stop, the reference shown in the literature sections features two full stops in a row, which is typographically awkward. I suggest adding a test to the xsl that checks if the titles ends in ".". If this is the case, skip the "." between title and place of publication. Example: https://berlin.museum-digital.de/object/113761 ![image](/attachments/e208567b-10ed-4a7b-bb48-285f37a0b003)

image.png

12 KiB

jrenslin commented

2023-04-27 17:43:48 +02:00

I am strongly against changing the LIDO output in such cases. If the title of a book is for example "Philipp II.", this incorrectly alters the data in favor of only one possible way of presentation.

I do however agree, that we could have it prettier in the frontend and strip out duplicate dots when generating the citation there.

See: museum-digital/frontend#322

I am strongly against changing the LIDO output in such cases. If the title of a book is for example "Philipp II.", this incorrectly alters the data in favor of only one possible way of presentation. I do however agree, that we could have it prettier in the frontend and strip out duplicate dots when generating the citation there. See: https://gitea.armuli.eu/museum-digital/frontend/issues/322

jrenslin closed this issue

2023-04-27 17:43:48 +02:00

awinkler commented

2023-04-27 20:28:46 +02:00

I'm not sure if I'm convinced. The HTML representation is perfect now thanks to 8af08b50db .

In the EAD-LIDO (https://berlin.museum-digital.de/object/113761?output=ead), the only LIDO where the bibliography shows up, there is a complete bibliographic reference and no structured data. If it was structured (as in the JSON, e.g.), I'd absolutely agree. Being a full-text citation, I'd expect the usual citation styles to apply. These don't usually allow two dots in a row (cf. Chicago Manual of Style 6.14: "When an expression that ends in a period (e.g., an abbreviation) falls at the end of a sentence, no additional period follows.").

Strangely, the LIDO export (generated by @anowicki some time ago not via the HTML interface but in the editor mode), has <lido:displayObject>Dietmar Lemcke, 2003: Dietmar Lemcke. Bilder, Aquarelle, Zeichnungen. 1958 - 2003., Berlin</lido:displayObject>, which is acceptable – and it's usually these LIDOs that are passed on to platform that cannot eliminate the second dot. So that's really a minor issue.

I'm not sure if I'm convinced. The HTML representation is perfect now thanks to https://gitea.armuli.eu/museum-digital/frontend/commit/8af08b50dbcb6043faefb8da9d853518c387033b . In the EAD-LIDO (https://berlin.museum-digital.de/object/113761?output=ead), the only LIDO where the bibliography shows up, there is a complete bibliographic reference and no structured data. If it was structured (as in the JSON, e.g.), I'd absolutely agree. Being a full-text citation, I'd expect the usual citation styles to apply. These don't usually allow two dots in a row (cf. Chicago Manual of Style 6.14: "When an expression that ends in a period (e.g., an abbreviation) falls at the end of a sentence, no additional period follows."). Strangely, the LIDO export (generated by @anowicki some time ago not via the HTML interface but in the editor mode), has `<lido:displayObject>Dietmar Lemcke, 2003: Dietmar Lemcke. Bilder, Aquarelle, Zeichnungen. 1958 - 2003., Berlin</lido:displayObject>`, which is acceptable – and it's usually these LIDOs that are passed on to platform that cannot eliminate the second dot. So that's really a minor issue.

jrenslin commented

2023-04-27 22:17:26 +02:00

Good point on EAD. On a general note, it's only the export XML in musdb that is generated using the XSLs in this repository. XML outputs in the frontend are implemented fully in PHP (say, better performance but less easy to adjust and share).

See museum-digital/frontend#323

Good point on EAD. On a general note, it's only the export XML in musdb that is generated using the XSLs in this repository. XML outputs in the frontend are implemented fully in PHP (say, better performance but less easy to adjust and share). See https://gitea.armuli.eu/museum-digital/frontend/issues/323

Sign in to join this conversation.