Check if title ends with full stop #3
Closed
opened 2023-04-27 12:20:13 +02:00 by awinkler
·
3 comments
Labels
Clear labels
kind/breaking
Critical issue that breaks a page
kind/bug
Something is not working
kind/docs
This concerns the documentation
kind/enhancement
Improvements on existing features
kind/feature
New features
kind/lint
Code linting error
kind/proposal
Suggestion or proposal
kind/question
A question
kind/refactor
Refactoring code
kind/security
Security issue
kind/testing
Concerns the test setup
kind/translation
Concerns multilinguality
kind/ui
Concerns the user interface
priority/critical
Critical issue, highest priority
priority/high
High priority issue
priority/low
Low priority issue
priority/medium
Medium priority issue
reviewed/duplicate
This is a duplicate
reviewed/invalid
This is an invalid issue
reviewed/wontfix
This is issue will not be fixed
status/done
This issue has been fixed
status/needs-feedback
This issue needs feedback
kind/breaking
Critical issue that breaks a page
kind/bug
Something is not working
kind/docs
This concerns the documentation
kind/enhancement
Improvements on existing features
kind/feature
New features
kind/lint
Code linting error
kind/proposal
Suggestion or proposal
kind/question
A question
kind/refactor
Refactoring code
kind/security
Security issue
kind/testing
Concerns the test setup
kind/translation
Concerns multilinguality
kind/ui
Concerns the user interface
priority/critical
Critical issue, highest priority
priority/high
High priority issue
priority/low
Low priority issue
priority/medium
Medium priority issue
reviewed/duplicate
This is a duplicate
reviewed/invalid
This is an invalid issue
reviewed/wontfix
This is issue will not be fixed
status/done
This issue has been fixed
status/needs-feedback
This issue needs feedback
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
abecker
adamm
akoch
anowicki
arnel
awinkler
bbaumecker
bednarikj
cbecker
cmagdo
cotte
cpitzen
dyanc
emalygina
fvhagel
hkuper
hwarth-geraci
jjuergens
jrenslin
jvpilgrim
korilo
krifo
manders
mhartmann
mkarbe
mkisser
mportius
neikermann
nfuelbier
nklingspor
shollmann
sopfermann
stefan
swassermann
szunkel
ufladerer
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: museum-digital/musdb-md-xm-xsls#3
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently, if a title ends with a full stop, the reference shown in the literature sections features two full stops in a row, which is typographically awkward. I suggest adding a test to the xsl that checks if the titles ends in ".". If this is the case, skip the "." between title and place of publication.
Example: https://berlin.museum-digital.de/object/113761
I am strongly against changing the LIDO output in such cases. If the title of a book is for example "Philipp II.", this incorrectly alters the data in favor of only one possible way of presentation.
I do however agree, that we could have it prettier in the frontend and strip out duplicate dots when generating the citation there.
See: museum-digital/frontend#322
I'm not sure if I'm convinced. The HTML representation is perfect now thanks to
8af08b50db
.In the EAD-LIDO (https://berlin.museum-digital.de/object/113761?output=ead), the only LIDO where the bibliography shows up, there is a complete bibliographic reference and no structured data. If it was structured (as in the JSON, e.g.), I'd absolutely agree. Being a full-text citation, I'd expect the usual citation styles to apply. These don't usually allow two dots in a row (cf. Chicago Manual of Style 6.14: "When an expression that ends in a period (e.g., an abbreviation) falls at the end of a sentence, no additional period follows.").
Strangely, the LIDO export (generated by @anowicki some time ago not via the HTML interface but in the editor mode), has
<lido:displayObject>Dietmar Lemcke, 2003: Dietmar Lemcke. Bilder, Aquarelle, Zeichnungen. 1958 - 2003., Berlin</lido:displayObject>
, which is acceptable – and it's usually these LIDOs that are passed on to platform that cannot eliminate the second dot. So that's really a minor issue.Good point on EAD. On a general note, it's only the export XML in musdb that is generated using the XSLs in this repository. XML outputs in the frontend are implemented fully in PHP (say, better performance but less easy to adjust and share).
See museum-digital/frontend#323