museum-digital/musdb-md-xm-xsls
41
0
Fork 2
Code Issues 8 Pull Requests Projects Releases Wiki Activity

update mapping to lido:relatedWork to fill gaps and improve DDB compatibility #17

Merged
anowicki merged 3 commits from anowicki/musdb-md-xm-xsls:master into master 2026-02-26 15:44:32 +01:00
Conversation 4 Commits 3 Files Changed 1
+23 -7
anowicki commented 2026-02-20 18:34:26 +01:00
Member
Copy Link
Copy Source
No description provided.
anowicki added the kind/bug label 2026-02-20 18:34:26 +01:00
anowicki added 3 commits 2026-02-20 18:34:26 +01:00
update mapping literature_online from lido:objectID to lido:objectWebResource 6f17a9c81d
add check for empty element (literatur_isbn, literatur_gnd) to avoid creation of empty LIDO element 06edc8ac8c
add mapping from objectToObjectLinkSet to lido:relatedWork, includig lido:displayObject and lido:objectWebResource b7d7c15407
anowicki requested review from jrenslin 2026-02-20 18:34:26 +01:00
jrenslin commented 2026-02-23 12:39:47 +01:00
Owner
Copy Link
Copy Source

The mapping of literature links to objectID over objectWebResource does not work. Literature links often lead to some library's online viewer or such. Actually referencing a permalink should be rare. Instances, in which users reference a URL that would actually work as an ID in a LOD context is very likely the case in less than 10% of links with literature links.

The mapping of literature links to `objectID` over `objectWebResource` does not work. Literature links often lead to some library's online viewer or such. Actually referencing a permalink should be rare. Instances, in which users reference a URL that would actually work as an ID in a LOD context is very likely the case in less than 10% of links with literature links.
jrenslin commented 2026-02-23 12:40:15 +01:00
Owner
Copy Link
Copy Source

The rest looks good so far.

The rest looks good so far.
anowicki commented 2026-02-23 13:48:48 +01:00
Author
Member
Copy Link
Copy Source

The mapping of literature links to objectID over objectWebResource does not work. Literature links often lead to some library's online viewer or such. Actually referencing a permalink should be rare. Instances, in which users reference a URL that would actually work as an ID in a LOD context is very likely the case in less than 10% of links with literature links.

Doesn't this support the mapping update to literature_online => lido:objectWebResource? The current master maps literature_online => lido:objectID.

> The mapping of literature links to `objectID` over `objectWebResource` does not work. Literature links often lead to some library's online viewer or such. Actually referencing a permalink should be rare. Instances, in which users reference a URL that would actually work as an ID in a LOD context is very likely the case in less than 10% of links with literature links. Doesn't this support the mapping update to literature_online => lido:objectWebResource? The current master maps literature_online => lido:objectID.
jrenslin commented 2026-02-24 11:09:59 +01:00
Owner
Copy Link
Copy Source

Oh, sorry! I must have read the diff the wrong way around. Then I was criticizing the current implementation and yours is perfectly correct.

Oh, sorry! I must have read the diff the wrong way around. Then I was criticizing the current implementation and yours is perfectly correct.
anowicki marked the pull request as ready for review 2026-02-26 15:41:03 +01:00
anowicki merged commit 37ac8fc4f9 into master 2026-02-26 15:44:32 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
jrenslin
Labels
Clear labels
kind/breaking
Critical issue that breaks a page
 kind/bug
Something is not working
 kind/docs
This concerns the documentation
 kind/enhancement
Improvements on existing features
 kind/feature
New features
 kind/lint
Code linting error
 kind/proposal
Suggestion or proposal
 kind/question
A question
 kind/refactor
Refactoring code
 kind/security
Security issue
 kind/testing
Concerns the test setup
 kind/translation
Concerns multilinguality
 kind/ui
Concerns the user interface
 priority/critical
Critical issue, highest priority
 priority/high
High priority issue
 priority/low
Low priority issue
 priority/medium
Medium priority issue
 reviewed/duplicate
This is a duplicate
 reviewed/invalid
This is an invalid issue
 reviewed/wontfix
This is issue will not be fixed
 status/done
This issue has been fixed
 status/needs-feedback
This issue needs feedback
kind/breaking
Critical issue that breaks a page
 kind/bug
Something is not working
 kind/docs
This concerns the documentation
 kind/enhancement
Improvements on existing features
 kind/feature
New features
 kind/lint
Code linting error
 kind/proposal
Suggestion or proposal
 kind/question
A question
 kind/refactor
Refactoring code
 kind/security
Security issue
 kind/testing
Concerns the test setup
 kind/translation
Concerns multilinguality
 kind/ui
Concerns the user interface
 priority/critical
Critical issue, highest priority
 priority/high
High priority issue
 priority/low
Low priority issue
 priority/medium
Medium priority issue
 reviewed/duplicate
This is a duplicate
 reviewed/invalid
This is an invalid issue
 reviewed/wontfix
This is issue will not be fixed
 status/done
This issue has been fixed
 status/needs-feedback
This issue needs feedback
No Label kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
abecker adamm (Ádám Magyarosi) agoll akoch (Anne-Katrin Koch) aminnig anowicki (Anna-Lena Nowicki) arnel (Arne Lindemann) awinkler (Alexander Winkler) bbaumecker bednarikj (Bednárik János) cmagdo (Csaba) cotte cpitzen dyanc emalygina fvhagel hkuper (Heinz-Günter Kuper) hwarth-geraci jjuergens (Johanna Jürgens) jrenslin (Joshua Ramon Enslin) jvpilgrim (Jens von Pilgrim) korilo (Korinna Lorz) krifo (Krisztian Fonyodi) lluethi manders (Miriam Anders) mhartmann (Manfred Hartmann) mkarbe (Matthias Karbe) mkisser (Mirko Kisser) mportius (Martin Portius) neikermann nfuelbier nklingspor nyakubovich sfusetti shollmann slorbeer sopfermann stefan swassermann szunkel (Stefan Zunkel) ufladerer
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: museum-digital/musdb-md-xm-xsls#17
Delete Branch "anowicki/musdb-md-xm-xsls:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?