museum-digital/csvxml
35
0
Fork 0
Code Issues 2 Pull Requests Releases Activity

added tests and fixed leftover array entries

Browse Source
This commit is contained in:
Nathan Eikermann
2021-05-10 22:37:38 +02:00
parent 69d10cf8d0
commit 3bd176d4fc
2 changed files with 47 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
classes/CsvxmlAvailableFields.php
View File

@ -36,17 +36,18 @@ final class CsvxmlAvailableFields {
* @param boolean $required Determines whether the field is required. Defaults
to false.
*
* @return array
* @return FieldEntry
*/
private function _getSimpleAvailableFieldEntry(string $nameTL = "", string $explica = "", array $dependsOn = [], array $allowedValues = [], string $remark = "", bool $required = false):array {
return [
"required" => $required,
"allowedValues" => $allowedValues,
"dependsOn" => $dependsOn,
"remark" => $remark,
"name_human_readable" => $nameTL,
"explica" => $explica,
];
private function _getSimpleAvailableFieldEntry(string $nameTL = "", string $explica = "", array $dependsOn = [], array $allowedValues = [], string $remark = "", bool $required = false):FieldEntry
{
return new FieldEntry(
$required,
$allowedValues,
$dependsOn,
$remark,
$nameTL,
$explica
);
}
@ -59,9 +60,10 @@ final class CsvxmlAvailableFields {
* @param string $type Event type name (e.g. production).
* @param integer $number Number of event of this type.
*
* @return array
* @return FieldEntry
*/
private function _generateGenericFullEvent(array $event, MDTlLoader $tlLoader, string $typeName, string $type, int $number):array {
private function _generateGenericFullEvent(array $event, MDTlLoader $tlLoader, string $typeName, string $type, int $number):array
{
return [
"{$type}_when{$number}" => $this->_getSimpleAvailableFieldEntry("{$typeName}: {$event['when']}", "", ["{$type}_when_sure{$number}"]),