From 5433811176d3c34664211241db43209f4c96ae96 Mon Sep 17 00:00:00 2001
From: Joshua Ramon Enslin <joshua@museum-digital.de>
Date: Tue, 25 Mar 2025 14:57:29 +0100
Subject: [PATCH] Use dedicated exceptions if unlinking failed for reasons
 other than the file not existing

---
 exceptions/MDFailedToDeleteFile.php       | 18 ++++++++++++++++++
 exceptions/MDFilePermissionsException.php | 18 ++++++++++++++++++
 src/MD_STD.php                            | 10 +++++++++-
 3 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 exceptions/MDFailedToDeleteFile.php
 create mode 100644 exceptions/MDFilePermissionsException.php

diff --git a/exceptions/MDFailedToDeleteFile.php b/exceptions/MDFailedToDeleteFile.php
new file mode 100644
index 0000000..06c1bc4
--- /dev/null
+++ b/exceptions/MDFailedToDeleteFile.php
@@ -0,0 +1,18 @@
+<?PHP
+declare(strict_types = 1);
+
+/**
+ * Reports a failure to create a new directory.
+ */
+final class MDFailedToDeleteFile extends Exception {
+    /**
+     * Error message.
+     *
+     * @return string
+     */
+    public function errorMessage() {
+        //error message
+        return 'Failed to delete file';
+
+    }
+}
diff --git a/exceptions/MDFilePermissionsException.php b/exceptions/MDFilePermissionsException.php
new file mode 100644
index 0000000..619310e
--- /dev/null
+++ b/exceptions/MDFilePermissionsException.php
@@ -0,0 +1,18 @@
+<?PHP
+declare(strict_types = 1);
+
+/**
+ * Reports a failure due to insufficient permissions in the file system.
+ */
+final class MDFilePermissionsException extends Exception {
+    /**
+     * Error message.
+     *
+     * @return string
+     */
+    public function errorMessage() {
+        //error message
+        return 'Insufficient file system permissions';
+
+    }
+}
diff --git a/src/MD_STD.php b/src/MD_STD.php
index b6c2650..e499c24 100644
--- a/src/MD_STD.php
+++ b/src/MD_STD.php
@@ -110,7 +110,15 @@ final class MD_STD {
     public static function unlink(string $filename):void {
 
         if (\unlink($filename) === false) {
-            throw new MDFileDoesNotExist("Failed to delete: $filename");
+            if (!\is_file($filename)) {
+                throw new MDFileDoesNotExist("Failed to delete $filename, it did not exist");
+            }
+            else if (!\is_writable(dirname($filename))) {
+                throw new MDFilePermissionsException("Failed to delete $filename");
+            }
+            else {
+                throw new MDFailedToDeleteFile("Failed to delete $filename");
+            }
         }
 
     }