From 8018f7309ae68048e0d0b57be2a44d82f0693881 Mon Sep 17 00:00:00 2001
From: Joshua Ramon Enslin <joshua@museum-digital.de>
Date: Fri, 25 Feb 2022 18:56:15 +0100
Subject: [PATCH] Disallow escapeshellcmd, prefer escapeshellarg

---
 rules/md_phpcs_rules.xml       | 2 +-
 rules/md_phpcs_rules_basic.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/rules/md_phpcs_rules.xml b/rules/md_phpcs_rules.xml
index 058aece..e139381 100644
--- a/rules/md_phpcs_rules.xml
+++ b/rules/md_phpcs_rules.xml
@@ -177,7 +177,7 @@
                 <element key="sizeof" value="count"/>
             </property>
             -->
-            <property name="forbiddenFunctions" type="array" value="delete=>unset,print=>echo,create_function=>null,system=>null,sizeof=>count,mysql_query=>mysqli_query,mysqli_query=>null,mysql_num_rows=>mysqli_num_rows,mysqli_num_rows=>null,mysql_error=>mysqli_error,mysqli_stmt_init=>null,mysqli_stmt_close=>null,mysqli_real_escape_string=>null,mysqli_fetch_array=>mysqli_fetch_assoc,mysqli_fetch_assoc=>null,session_id=>null,print_r=>null,var_dump=>null" />
+            <property name="forbiddenFunctions" type="array" value="delete=>unset,print=>echo,create_function=>null,system=>null,sizeof=>count,mysql_query=>mysqli_query,mysqli_query=>null,mysql_num_rows=>mysqli_num_rows,mysqli_num_rows=>null,mysql_error=>mysqli_error,mysqli_stmt_init=>null,mysqli_stmt_close=>null,mysqli_real_escape_string=>null,mysqli_fetch_array=>mysqli_fetch_assoc,mysqli_fetch_assoc=>null,session_id=>null,print_r=>null,var_dump=>null,escapeshellcmd=>escapeshellarg" />
         </properties>
     </rule>
 
diff --git a/rules/md_phpcs_rules_basic.xml b/rules/md_phpcs_rules_basic.xml
index 41c5909..ba0dd81 100644
--- a/rules/md_phpcs_rules_basic.xml
+++ b/rules/md_phpcs_rules_basic.xml
@@ -126,7 +126,7 @@
                 <element key="sizeof" value="count"/>
             </property>
             -->
-            <property name="forbiddenFunctions" type="array" value="delete=>unset,print=>echo,create_function=>null,system=>null,sizeof=>count" />
+            <property name="forbiddenFunctions" type="array" value="delete=>unset,print=>echo,create_function=>null,system=>null,sizeof=>count,escapeshellcmd=>escapeshellarg" />
         </properties>
     </rule>