museum-digital/MDQualityAssessment
36
0 Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix order of if-else block (check time ending before actor is born (=

Browse Source 
full warning) before checking time starting before actor birth (limited
warning))
This commit is contained in:
jrenslin committed 2023-10-06 23:22:52 +02:00
1 parent 7596d9f18e
commit aef095af3c
2 files changed
+31 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/Checks/Plausi/MDPlausi.php
+6 -6
View File
@@ -52,19 +52,19 @@ private function _checkPlausibilityOnBirthDeath():void {
// Evaluating actor birth
if ($event->actor_birth_normalized !== false) {
// Work on the object started before the actor was born
if ($event->time_start_normalized !== false && $event->time_start_normalized < $event->actor_birth_normalized) {
$this->_messageList[] = $this->_tlLoader->tl("eventtype_name", "eventname", (string)$event->event_type) . ' (' . $event->time_name . ') ' . $this->_tlLoader->tl("quality", "quality", "before_birth_possibly") . ' ' . $event->actor_name;
}
// The actor was involved with the object totally before they were born
// Ended being involved before birth
else if ($event->time_end_normalized !== false && $event->time_end_normalized < $event->actor_birth_normalized) {
if ($event->time_end_normalized !== false && $event->time_end_normalized < $event->actor_birth_normalized) {
$this->_messageList[] = $this->_tlLoader->tl("eventtype_name", "eventname", (string)$event->event_type) . ' (' . $event->time_name . ') ' . $this->_tlLoader->tl("quality", "quality", "before_birth") . ' ' . $event->actor_name;
$this->_hasCertainWarnings = true;
}
// Work on the object started before the actor was born
else if ($event->time_start_normalized !== false && $event->time_start_normalized < $event->actor_birth_normalized) {
$this->_messageList[] = $this->_tlLoader->tl("eventtype_name", "eventname", (string)$event->event_type) . ' (' . $event->time_name . ') ' . $this->_tlLoader->tl("quality", "quality", "before_birth_possibly") . ' ' . $event->actor_name;
}
}
// Evaluate actor death