From a0621216ecc8dbd1d19d43c435ee247ec95bd7f7 Mon Sep 17 00:00:00 2001 From: Joshua Ramon Enslin Date: Tue, 11 Jun 2024 19:12:27 +0200 Subject: [PATCH] Use QI multiplier for evaluating markings in PuQI, set explicit constant visibility --- src/Checks/Puqi/MDPuqi.php | 120 ++++++++++++++++++------------------- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/src/Checks/Puqi/MDPuqi.php b/src/Checks/Puqi/MDPuqi.php index bbf8930..ad671f4 100644 --- a/src/Checks/Puqi/MDPuqi.php +++ b/src/Checks/Puqi/MDPuqi.php @@ -30,71 +30,71 @@ final class MDPuqi { private const THRESHOLD_CC_OBJECT_DESC_GREAT = 1750; private const THRESHOLD_CC_OBJECT_DESC_QUITE_LONG = 5000; - const THRESHOLD_TAGS_TOO_MANY = 10; - const THRESHOLD_IMG_TOO_SMALL = 600; // px - const THRESHOLD_IMG_SMALL = 800; // px - const THRESHOLD_IMG_GOOD_SIZE_SHORTER = 1200; // px - const THRESHOLD_IMG_GOOD_SIZE_LONGER = 1920; // px + public const THRESHOLD_TAGS_TOO_MANY = 10; + public const THRESHOLD_IMG_TOO_SMALL = 600; // px + public const THRESHOLD_IMG_SMALL = 800; // px + public const THRESHOLD_IMG_GOOD_SIZE_SHORTER = 1200; // px + public const THRESHOLD_IMG_GOOD_SIZE_LONGER = 1920; // px - const LICENSES_OPEN_ACCESS_PD = ["CC0", "Public Domain Mark", "Orphan Work"]; - const LICENSES_OPEN_ACCESS_ATTRIBUTION = ["CC BY"]; - const LICENSES_CLOSED_ACCESS = ["RR-F", "RR-P", "RR-R"]; + public const LICENSES_OPEN_ACCESS_PD = ["CC0", "Public Domain Mark", "Orphan Work"]; + public const LICENSES_OPEN_ACCESS_ATTRIBUTION = ["CC BY"]; + public const LICENSES_CLOSED_ACCESS = ["RR-F", "RR-P", "RR-R"]; - const QI_REWARD_DESCRIPTION_LENGTH_GOOD = 3; - const QI_REWARD_DESCRIPTION_LENGTH_GREAT = 6; - const QI_REWARD_EVENTS_MULTIPLIER = 5; - const QI_REWARD_TAGS_MULTIPLIER = 3; - const QI_REWARD_LITERATURE_MULTIPLIER = 2; - const QI_REWARD_HYPERLINKS_MULTIPLIER = 2; - const QI_REWARD_DOCUMENTS_MULTIPLIER = 1; - const QI_REWARD_LINKED_OBJS_MULTIPLIER = 3; - const QI_REWARD_SERIES_MULTIPLIER = 4; - const QI_REWARD_EXHIBITIONS_MULTIPLIER = 4; - const QI_REWARD_TRANSLATIONS_MULTIPLIER = 10; - const QI_REWARD_TRANSCRIPTS_MULTIPLIER = 10; - const QI_REWARD_OBJ_IS_REF_MULTIPLIER = 5; - const QI_REWARD_OBJ_RECEPTION_MULTIPLIER = 1; - const QI_REWARD_MARKINGS_MULTIPLIER = 3; - const QI_REWARD_IMGS_RESOURCES_MULTIPLIER = 3; - const QI_REWARD_IMAGE_SIZE_LARGE = 1; - const QI_REWARD_IMAGE_LICENCE_OPEN_ACCESS = 2; - const QI_REWARD_IMAGE_LICENCE_OPEN_ACCESS_ATTRIBUTION = 1; - const QI_REWARD_METADATA_LICENCE_OPEN_ACCESS = 5; - const QI_REWARD_METADATA_LICENCE_OPEN_ACCESS_ATTRIBUTION = 3; + public const QI_REWARD_DESCRIPTION_LENGTH_GOOD = 3; + private const QI_REWARD_DESCRIPTION_LENGTH_GREAT = 6; + private const QI_REWARD_EVENTS_MULTIPLIER = 5; + private const QI_REWARD_TAGS_MULTIPLIER = 3; + private const QI_REWARD_LITERATURE_MULTIPLIER = 2; + private const QI_REWARD_HYPERLINKS_MULTIPLIER = 2; + private const QI_REWARD_DOCUMENTS_MULTIPLIER = 1; + private const QI_REWARD_LINKED_OBJS_MULTIPLIER = 3; + private const QI_REWARD_SERIES_MULTIPLIER = 4; + private const QI_REWARD_EXHIBITIONS_MULTIPLIER = 4; + private const QI_REWARD_TRANSLATIONS_MULTIPLIER = 10; + private const QI_REWARD_TRANSCRIPTS_MULTIPLIER = 10; + private const QI_REWARD_OBJ_IS_REF_MULTIPLIER = 5; + private const QI_REWARD_OBJ_RECEPTION_MULTIPLIER = 1; + private const QI_REWARD_MARKINGS_MULTIPLIER = 3; + private const QI_REWARD_IMGS_RESOURCES_MULTIPLIER = 3; + private const QI_REWARD_IMAGE_SIZE_LARGE = 1; + private const QI_REWARD_IMAGE_LICENCE_OPEN_ACCESS = 2; + private const QI_REWARD_IMAGE_LICENCE_OPEN_ACCESS_ATTRIBUTION = 1; + private const QI_REWARD_METADATA_LICENCE_OPEN_ACCESS = 5; + private const QI_REWARD_METADATA_LICENCE_OPEN_ACCESS_ATTRIBUTION = 3; - const QI_REWARD_PUBLIC_INSCRIPTION = 3; - const QI_REWARD_PUBLIC_COMPARABLE_OBJECTS = 3; - const QI_REWARD_PUBLIC_DETAILED_DESCRIPTION = 5; + private const QI_REWARD_PUBLIC_INSCRIPTION = 3; + private const QI_REWARD_PUBLIC_COMPARABLE_OBJECTS = 3; + private const QI_REWARD_PUBLIC_DETAILED_DESCRIPTION = 5; - const QI_PENALTY_EMPTY_OBJECT_TYPE = -20; - const QI_PENALTY_TITLE_ONE_WORD = -3; - const QI_PENALTY_TITLE_DUPLICATE = -5; - const QI_PENALTY_TITLE_TOO_LONG = -5; - const QI_PENALTY_DESCRIPTION_DUPLICATE = -25; - const QI_PENALTY_DESCRIPTION_TOO_SHORT = -10; - const QI_PENALTY_DESCRIPTION_SHORT = -5; - const QI_PENALTY_DESCRIPTION_TOO_LONG = -6; - const QI_PENALTY_EMPTY_MATTECH = -3; - const QI_PENALTY_EMPTY_MEASUREMENTS = -5; + private const QI_PENALTY_EMPTY_OBJECT_TYPE = -20; + private const QI_PENALTY_TITLE_ONE_WORD = -3; + private const QI_PENALTY_TITLE_DUPLICATE = -5; + private const QI_PENALTY_TITLE_TOO_LONG = -5; + private const QI_PENALTY_DESCRIPTION_DUPLICATE = -25; + private const QI_PENALTY_DESCRIPTION_TOO_SHORT = -10; + private const QI_PENALTY_DESCRIPTION_SHORT = -5; + private const QI_PENALTY_DESCRIPTION_TOO_LONG = -6; + private const QI_PENALTY_EMPTY_MATTECH = -3; + private const QI_PENALTY_EMPTY_MEASUREMENTS = -5; - const QI_PENALTY_NO_IMAGE = -10; - const QI_PENALTY_NO_COLLECTION = -10; - const QI_PENALTY_MULTIPLIER_EVENT_PART_DOUBLE_LINKED_AS_RELATED = -10; - const QI_PENALTY_NO_EVENTS = -15; - const QI_PENALTY_NO_TAG = -15; - const QI_PENALTY_ONLY_ONE_TAG = -10; - const QI_PENALTY_ONLY_TWO_TAG = -5; - const QI_PENALTY_TOO_MANY_TAGS = -3; // Per tag of more than 10 tags + private const QI_PENALTY_NO_IMAGE = -10; + private const QI_PENALTY_NO_COLLECTION = -10; + private const QI_PENALTY_MULTIPLIER_EVENT_PART_DOUBLE_LINKED_AS_RELATED = -10; + private const QI_PENALTY_NO_EVENTS = -15; + private const QI_PENALTY_NO_TAG = -15; + private const QI_PENALTY_ONLY_ONE_TAG = -10; + private const QI_PENALTY_ONLY_TWO_TAG = -5; + private const QI_PENALTY_TOO_MANY_TAGS = -3; // Per tag of more than 10 tags - const QI_PENALTY_IMAGE_FILE_MISSING = -5; - const QI_PENALTY_IMAGE_TOO_SMALL = -5; - const QI_PENALTY_IMAGE_SMALL = -2; - const QI_PENALTY_IMAGE_NO_OWNER_NO_LICENCE = -15; - const QI_PENALTY_IMAGE_NO_OWNER = -10; - const QI_PENALTY_IMAGE_NO_LICENCE = -10; - const QI_PENALTY_IMAGE_LICENCE_CLOSED_ACCESS = -1; - const QI_PENALTY_METADATA_NO_LICENCE = -10; - const QI_PENALTY_METADATA_LICENCE_CLOSED_ACCESS = -3; + private const QI_PENALTY_IMAGE_FILE_MISSING = -5; + private const QI_PENALTY_IMAGE_TOO_SMALL = -5; + private const QI_PENALTY_IMAGE_SMALL = -2; + private const QI_PENALTY_IMAGE_NO_OWNER_NO_LICENCE = -15; + private const QI_PENALTY_IMAGE_NO_OWNER = -10; + private const QI_PENALTY_IMAGE_NO_LICENCE = -10; + private const QI_PENALTY_IMAGE_LICENCE_CLOSED_ACCESS = -1; + private const QI_PENALTY_METADATA_NO_LICENCE = -10; + private const QI_PENALTY_METADATA_LICENCE_CLOSED_ACCESS = -3; public const INDICATOR_THRESHOLD_COLOR_RED = -30; public const INDICATOR_THRESHOLD_COLOR_BLUE = 10; @@ -740,7 +740,7 @@ final class MDPuqi { MDPuqiCheckSection::markingCount, MDPuqiMessageStatus::praise, $this->_tlLoader->tl("quality", "quality", "markings_exist"), - self::QI_REWARD_OBJ_IS_REF_MULTIPLIER * $count, + self::QI_REWARD_MARKINGS_MULTIPLIER * $count, ); }