museum-digital/MDQualityAssessment
37
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove superfluous underscores in class member names

Browse Source 
The underscores indicated private members, where they were public.
This commit is contained in:
Joshua Ramon Enslin
2023-10-10 11:27:56 +02:00
parent 9af9eb0560
commit 8500a401d0
1 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

84
src/Checks/Minimaldatensatz/MinimaldatensatzCheck.php
View File

@@ -19,19 +19,19 @@ declare(strict_types = 1);
*/ */
final class MinimaldatensatzCheck { final class MinimaldatensatzCheck {
public bool $_has_title; public bool $has_title;
public bool $_has_type; public bool $has_type;
public bool $_has_topic_category; public bool $has_topic_category;
public bool $_has_inventory_number; public bool $has_inventory_number;
public bool $_has_description; public bool $has_description;
public bool $_has_material; public bool $has_material;
public bool $_has_technique; public bool $has_technique;
public bool $_has_measurements; public bool $has_measurements;
public bool $_has_event; public bool $has_event;
public bool $_has_tag; public bool $has_tag;
public bool $_has_image; public bool $has_image;
public bool $_has_image_license; public bool $has_image_license;
public bool $_has_image_owner; public bool $has_image_owner;
/** /**
* Returns an evaluation message for a given required field. * Returns an evaluation message for a given required field.
@@ -40,7 +40,7 @@ final class MinimaldatensatzCheck {
* @param boolean $passed Sets whether the field is available and filled or not. * @param boolean $passed Sets whether the field is available and filled or not.
* @param string $fieldname_de German language field name. * @param string $fieldname_de German language field name.
* *
* @return array{field: string, passed: bool, text: string} * @return array{field: string, required: true, passed: bool, text: string}
*/ */
private function _generateOutputMessageForRequiredField(string $field, bool $passed, string $fieldname_de):array { private function _generateOutputMessageForRequiredField(string $field, bool $passed, string $fieldname_de):array {
@@ -63,7 +63,7 @@ final class MinimaldatensatzCheck {
* @param boolean $passed Sets whether the field is available and filled or not. * @param boolean $passed Sets whether the field is available and filled or not.
* @param string $fieldname_de German language field name. * @param string $fieldname_de German language field name.
* *
* @return array{field: string, passed: bool, text: string} * @return array{field: string, required: false, passed: bool, text: string}
*/ */
private function _generateOutputMessageForOptionalField(string $field, bool $passed, string $fieldname_de):array { private function _generateOutputMessageForOptionalField(string $field, bool $passed, string $fieldname_de):array {
@@ -82,50 +82,50 @@ final class MinimaldatensatzCheck {
/** /**
* Returns a list of evaluations / checks for each field. * Returns a list of evaluations / checks for each field.
* *
* @return array<array{field: string, required: bool, passed: bool, text: string}> * @return list<array{field: string, required: bool, passed: bool, text: string}>
*/ */
public function evaluate():array { public function evaluate():array {
$output = []; $output = [];
if (!isset($this->_has_title)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Title has not been checked"); if (!isset($this->has_title)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Title has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("title", $this->_has_title, "Objekttitel oder -benennung"); $output[] = $this->_generateOutputMessageForRequiredField("title", $this->has_title, "Objekttitel oder -benennung");
if (!isset($this->_has_type)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Type has not been checked"); if (!isset($this->has_type)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Type has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("type", $this->_has_type, "Objekttyp oder -bezeichnung"); $output[] = $this->_generateOutputMessageForRequiredField("type", $this->has_type, "Objekttyp oder -bezeichnung");
if (!isset($this->_has_topic_category)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Topic category has not been checked"); if (!isset($this->has_topic_category)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Topic category has not been checked");
$output[] = $this->_generateOutputMessageForOptionalField("topic_category", $this->_has_topic_category, "Themenkategorie"); $output[] = $this->_generateOutputMessageForOptionalField("topic_category", $this->has_topic_category, "Themenkategorie");
if (!isset($this->_has_inventory_number)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Inventory number has not been checked"); if (!isset($this->has_inventory_number)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Inventory number has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("inventory_number", $this->_has_inventory_number, "Inventarnummer"); $output[] = $this->_generateOutputMessageForRequiredField("inventory_number", $this->has_inventory_number, "Inventarnummer");
if (!isset($this->_has_description)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Description has not been checked"); if (!isset($this->has_description)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Description has not been checked");
$output[] = $this->_generateOutputMessageForOptionalField("description", $this->_has_description, "Objektbeschreibung"); $output[] = $this->_generateOutputMessageForOptionalField("description", $this->has_description, "Objektbeschreibung");
if (!isset($this->_has_material)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Material has not been checked"); if (!isset($this->has_material)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Material has not been checked");
$output[] = $this->_generateOutputMessageForOptionalField("material", $this->_has_material, "Material"); $output[] = $this->_generateOutputMessageForOptionalField("material", $this->has_material, "Material");
if (!isset($this->_has_technique)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Technique has not been checked"); if (!isset($this->has_technique)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Technique has not been checked");
$output[] = $this->_generateOutputMessageForOptionalField("technique", $this->_has_technique, "Technik"); $output[] = $this->_generateOutputMessageForOptionalField("technique", $this->has_technique, "Technik");
if (!isset($this->_has_measurements)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Measurements has not been checked"); if (!isset($this->has_measurements)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Measurements has not been checked");
$output[] = $this->_generateOutputMessageForOptionalField("measurements", $this->_has_measurements, "Maße"); $output[] = $this->_generateOutputMessageForOptionalField("measurements", $this->has_measurements, "Maße");
if (!isset($this->_has_event)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Event has not been checked"); if (!isset($this->has_event)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Event has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("event", $this->_has_event, "Ereignis in der Objektgeschichte (Feldgruppe)"); $output[] = $this->_generateOutputMessageForRequiredField("event", $this->has_event, "Ereignis in der Objektgeschichte (Feldgruppe)");
if (!isset($this->_has_tag)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Tag has not been checked"); if (!isset($this->has_tag)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Tag has not been checked");
$output[] = $this->_generateOutputMessageForOptionalField("tag", $this->_has_tag, "Inhaltsschlagwort"); $output[] = $this->_generateOutputMessageForOptionalField("tag", $this->has_tag, "Inhaltsschlagwort");
if (!isset($this->_has_image)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Image has not been checked"); if (!isset($this->has_image)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Image has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("image", $this->_has_image, "Mediendatei (Feldgruppe)"); $output[] = $this->_generateOutputMessageForRequiredField("image", $this->has_image, "Mediendatei (Feldgruppe)");
if (!isset($this->_has_image_license)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Image license has not been checked"); if (!isset($this->has_image_license)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Image license has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("image_license", $this->_has_image_license, "Nutzungsrechte Mediendatei"); $output[] = $this->_generateOutputMessageForRequiredField("image_license", $this->has_image_license, "Nutzungsrechte Mediendatei");
if (!isset($this->_has_image_owner)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Image owner has not been checked"); if (!isset($this->has_image_owner)) throw new MinimaldatensatzCheckIncompletelyImplementedException("Image owner has not been checked");
$output[] = $this->_generateOutputMessageForRequiredField("image_owner", $this->_has_image_owner, "Rechteinhaber*in Mediendatei"); $output[] = $this->_generateOutputMessageForRequiredField("image_owner", $this->has_image_owner, "Rechteinhaber*in Mediendatei");
return $output; return $output;