museum-digital/MDNodaHelpers
35
0
Fork 0
Code Issues 6 Pull Requests Releases Wiki Activity

Identify errors in autogenerating translations for times #30

New Issue
Closed
opened 2025-04-04 19:38:23 +02:00 by jrenslin · 0 comments
jrenslin commented 2025-04-04 19:38:23 +02:00
Owner
Copy Link

We currently have a bug in case of some autogenerated time translations: Seemingly depending on the time zone, some languages will move between years from 1912 to 1913 or such (it's consistent, but we still have not managed to identify why it happens or how to solve it; Once we moved to PHP's datetimeimmutable, the error appeared).

We can catch some of the errors and work around them if we check if the time begin and end years are contained in the translation string. This works for almost all languages, that use latin numbers.

We currently have a bug in case of some autogenerated time translations: Seemingly depending on the time zone, some languages will move between years from 1912 to 1913 or such (it's consistent, but we still have not managed to identify *why* it happens or how to solve it; Once we moved to PHP's datetimeimmutable, the error appeared). We can catch some of the errors and work around them if we check if the time begin and end years are contained in the translation string. This works for almost all languages, that use latin numbers.
jrenslin added the
kind/feature
 label 2025-04-04 19:38:23 +02:00
jrenslin self-assigned this 2025-04-04 19:38:23 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
kind/breaking
Critical issue that breaks a page
kind/bug
Something is not working
kind/docs
This concerns the documentation
kind/enhancement
Improvements on existing features
kind/feature
New features
kind/lint
Code linting error
kind/proposal
Suggestion or proposal
kind/question
A question
kind/refactor
Refactoring code
kind/security
Security issue
kind/testing
Concerns the test setup
kind/translation
Concerns multilinguality
kind/ui
Concerns the user interface
priority/critical
Critical issue, highest priority
priority/high
High priority issue
priority/low
Low priority issue
priority/medium
Medium priority issue
reviewed/duplicate
This is a duplicate
reviewed/invalid
This is an invalid issue
reviewed/wontfix
This is issue will not be fixed
status/done
This issue has been fixed
status/needs-feedback
This issue needs feedback
kind/breaking
Critical issue that breaks a page
kind/bug
Something is not working
kind/docs
This concerns the documentation
kind/enhancement
Improvements on existing features
kind/feature
New features
kind/lint
Code linting error
kind/proposal
Suggestion or proposal
kind/question
A question
kind/refactor
Refactoring code
kind/security
Security issue
kind/testing
Concerns the test setup
kind/translation
Concerns multilinguality
kind/ui
Concerns the user interface
priority/critical
Critical issue, highest priority
priority/high
High priority issue
priority/low
Low priority issue
priority/medium
Medium priority issue
reviewed/duplicate
This is a duplicate
reviewed/invalid
This is an invalid issue
reviewed/wontfix
This is issue will not be fixed
status/done
This issue has been fixed
status/needs-feedback
This issue needs feedback
No Label
kind/feature
Milestone
No items
No Milestone
Assignees
Clear assignees
abecker adamm akoch anowicki arnel awinkler bbaumecker bednarikj cbecker cmagdo cotte cpitzen dyanc emalygina fvhagel hkuper hwarth-geraci jjuergens jrenslin jvpilgrim korilo krifo manders mhartmann mkarbe mkisser mportius neikermann nfuelbier nklingspor shollmann sopfermann stefan swassermann szunkel ufladerer
No Assignees jrenslin
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: museum-digital/MDNodaHelpers#30
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?