museum-digital/MDNodaHelpers
35
0
Fork 0
Code Issues 6 Pull Requests Releases Wiki Activity

Remove superfluous variable assignments

Browse Source
This commit is contained in:
Joshua Ramon Enslin
2022-09-15 21:29:07 +02:00
parent 7c0ad9fa37
commit 5819caff91
12 changed files with 44 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Sync/NodaPersinstFulltextSync.php
View File

@ -28,11 +28,9 @@ final class NodaPersinstFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return;
}
$result->close();
$result = null;
$this->_mysqli_noda->do_update_query_large("DELETE FROM `persinst_fulltext`
WHERE NOT EXISTS (SELECT 1 FROM `persinst`
@ -58,7 +56,6 @@ final class NodaPersinstFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return [];
}
@ -70,7 +67,6 @@ final class NodaPersinstFulltextSync {
$toUpdate[$persinst_id] = $cur;
}
$result->close();
$result = null;
$tlResult = $this->_mysqli_noda->do_read_query("SELECT `persinst_translation`.`persinst_id`, `trans_name` AS `name`
FROM `persinst_translation`
@ -85,7 +81,6 @@ final class NodaPersinstFulltextSync {
else $translations[$persinst_id][] = $cur['name'];
}
$tlResult->close();
$tlResult = null;
$newEntries = [];
@ -126,7 +121,6 @@ final class NodaPersinstFulltextSync {
}
$updateStmt->close();
$updateStmt = null;
if (count($toUpdate) > 1) {
$this->_mysqli_noda->commit();

6
src/Sync/NodaPlaceFulltextSync.php
View File

@ -29,11 +29,9 @@ final class NodaPlaceFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return;
}
$result->close();
$result = null;
$this->_mysqli_noda->do_update_query_large("DELETE FROM `orte_fulltext`
WHERE NOT EXISTS (SELECT 1 FROM `orte`
@ -59,7 +57,6 @@ final class NodaPlaceFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return [];
}
@ -71,7 +68,6 @@ final class NodaPlaceFulltextSync {
$toUpdate[$ort_id] = $cur;
}
$result->close();
$result = null;
$tlResult = $this->_mysqli_noda->do_read_query("SELECT `ort_translation`.`ort_id`, `trans_name` AS `name`
FROM `ort_translation`
@ -86,7 +82,6 @@ final class NodaPlaceFulltextSync {
else $translations[$ort_id][] = $cur['name'];
}
$tlResult->close();
$tlResult = null;
$newEntries = [];
@ -127,7 +122,6 @@ final class NodaPlaceFulltextSync {
}
$updateStmt->close();
$updateStmt = null;
if (count($toUpdate) > 1) {
$this->_mysqli_noda->commit();

6
src/Sync/NodaSourceFulltextSync.php
View File

@ -29,11 +29,9 @@ final class NodaSourceFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return;
}
$result->close();
$result = null;
$this->_mysqli_noda->do_update_query_large("DELETE FROM `source_fulltext_search`
WHERE NOT EXISTS (SELECT 1 FROM `source`
@ -60,7 +58,6 @@ final class NodaSourceFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return [];
}
@ -73,7 +70,6 @@ final class NodaSourceFulltextSync {
$toUpdate[$source_id] = $cur;
}
$result->close();
$result = null;
$authorsResult = $this->_mysqli_noda->do_read_query("SELECT `source_author`.`source_id`, `persinst_anzeigename` AS `name`
FROM `persinst`, `source_author`
@ -89,7 +85,6 @@ final class NodaSourceFulltextSync {
else $authors[$source_id][] = $cur['name'];
}
$authorsResult->close();
$authorsResult = null;
$newEntries = [];
@ -131,7 +126,6 @@ final class NodaSourceFulltextSync {
}
$updateStmt->close();
$updateStmt = null;
if (count($toUpdate) > 1) {
$this->_mysqli_noda->commit();

6
src/Sync/NodaTagFulltextSync.php
View File

@ -29,11 +29,9 @@ final class NodaTagFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return;
}
$result->close();
$result = null;
$this->_mysqli_noda->do_update_query_large("DELETE FROM `tag_fulltext`
WHERE NOT EXISTS (SELECT 1 FROM `tag`
@ -59,7 +57,6 @@ final class NodaTagFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return [];
}
@ -71,7 +68,6 @@ final class NodaTagFulltextSync {
$toUpdate[$tag_id] = $cur;
}
$result->close();
$result = null;
$tlResult = $this->_mysqli_noda->do_read_query("SELECT `tag_translation`.`tag_id`, `trans_name` AS `name`
FROM `tag_translation`
@ -86,7 +82,6 @@ final class NodaTagFulltextSync {
else $translations[$tag_id][] = $cur['name'];
}
$tlResult->close();
$tlResult = null;
$newEntries = [];
@ -127,7 +122,6 @@ final class NodaTagFulltextSync {
}
$updateStmt->close();
$updateStmt = null;
if (count($toUpdate) > 1) {
$this->_mysqli_noda->commit();

6
src/Sync/NodaTimeFulltextSync.php
View File

@ -29,11 +29,9 @@ final class NodaTimeFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return;
}
$result->close();
$result = null;
$this->_mysqli_noda->do_update_query_large("DELETE FROM `zeiten_fulltext`
WHERE NOT EXISTS (SELECT 1 FROM `zeiten`
@ -59,7 +57,6 @@ final class NodaTimeFulltextSync {
if ($result->num_rows === 0) {
$result->close();
$result = null;
return [];
}
@ -71,7 +68,6 @@ final class NodaTimeFulltextSync {
$toUpdate[$zeit_id] = $cur;
}
$result->close();
$result = null;
$tlResult = $this->_mysqli_noda->do_read_query("SELECT `zeit_translation`.`zeit_id`, `trans_name` AS `name`
FROM `zeit_translation`
@ -86,7 +82,6 @@ final class NodaTimeFulltextSync {
else $translations[$time_id][] = $cur['name'];
}
$tlResult->close();
$tlResult = null;
$newEntries = [];
@ -127,7 +122,6 @@ final class NodaTimeFulltextSync {
}
$updateStmt->close();
$updateStmt = null;
if (count($toUpdate) > 1) {
$this->_mysqli_noda->commit();