From 27ac3f255aefcc4e4885d1b51c6333a34a7ea44b Mon Sep 17 00:00:00 2001
From: Joshua Ramon Enslin <joshua@museum-digital.de>
Date: Sat, 15 Feb 2025 13:36:50 +0100
Subject: [PATCH] Minor typing improvements

---
 src/NodaWikidataFetcher.php       | 2 +-
 tests/NodaWikidataFetcherTest.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/NodaWikidataFetcher.php b/src/NodaWikidataFetcher.php
index 721d0cb..19a7805 100644
--- a/src/NodaWikidataFetcher.php
+++ b/src/NodaWikidataFetcher.php
@@ -829,7 +829,7 @@ final class NodaWikidataFetcher {
                     $tDescription = "";
                 }
 
-                if ($tDescription !== '' && !empty($desc_cleaned = self::_cleanWikidataInput($tDescription))) {
+                if (!empty($titleFromWikipedia) && !empty($tDescription) && !empty($desc_cleaned = self::_cleanWikidataInput($tDescription))) {
                     # $descs[$lang] = $tDescription;
                     $output[$lang] = [
                         'label' => $titleFromWikipedia,
diff --git a/tests/NodaWikidataFetcherTest.php b/tests/NodaWikidataFetcherTest.php
index 1a007d2..0eec33e 100644
--- a/tests/NodaWikidataFetcherTest.php
+++ b/tests/NodaWikidataFetcherTest.php
@@ -41,7 +41,7 @@ final class NodaWikidataFetcherTest extends TestCase {
     /**
      * Data provider providing a Wikidata ID for a dedicated wikidata item for disambiguation pages.
      *
-     * @return array<string: array{0: string}>
+     * @return array<string, array{0: string}>
      */
     public static function disambiguationPageProvider():array {