Add check to prevent duplicate work in NodaValidationHelper

2026-08-12 13:56:34 +02:00
parent 6ff7026b8f
commit 10d3891bba
1 changed files with 7 additions and 2 deletions
@@ -161,14 +161,19 @@ final class NodaValidationHelper {
            throw new MDBlacklistedInputException("Term is blacklisted");
        }

+        // Check rewrites
+
        if ($existingPersinstId = NodaIDGetter::getPersinstIDByNamesAndRewrites($mysqli_noda, $lang, $persinst_name_en, $persinst_geburtsjahr, $persinst_sterbejahr, $context_identifier, $institution_id)) {
            return $existingPersinstId;
        }

+        if ($persinst_name_en !== $persinst_name) {
            if ($existingPersinstId = NodaIDGetter::getPersinstIDByNamesAndRewrites($mysqli_noda, $lang, $persinst_name, $persinst_geburtsjahr, $persinst_sterbejahr, $context_identifier, $institution_id)) {
                return $existingPersinstId;
            }
+        }

+        // Return 0, no ID found
        return 0;

    }