From e691f517f9d1b3a6b7977e9cf78dec5e095ed257 Mon Sep 17 00:00:00 2001
From: Joshua Ramon Enslin <joshua@museum-digital.de>
Date: Thu, 27 Aug 2020 16:14:18 +0200
Subject: [PATCH] Improve type-safety

---
 src/MDConsole.php       | 4 ++--
 src/MDOutputHandler.php | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/MDConsole.php b/src/MDConsole.php
index 15dee7b..bc30850 100644
--- a/src/MDConsole.php
+++ b/src/MDConsole.php
@@ -94,7 +94,7 @@ class MDConsole {
 
         $levelColor = self::CONSOLE_LEVEL_COLORS[$level];
 
-        if (empty($link))
+        if ($link === "")
             echo sprintf("\033[1;30;" . $levelColor . "m_____\033[0m\033[0m %-20s \033[40m::\033[0m # \033[32m%+9s\033[0m \033[40m::\033[0m 📝 %-50s \033[40m::\033[0m 📅 %+20s\n", $context, $editedNo, $additionalNote, $date);
         else
             echo sprintf("\033[1;30;" . $levelColor . "m_____\033[0m\033[0m %-20s \033[40m::\033[0m # \033[32m%+9s\033[0m \033[40m::\033[0m 📝 %-50s \033[40m::\033[0m 📅 %+20s \033[40m::\033[0m $link\n", $context, $editedNo, $additionalNote, $date);;
@@ -109,7 +109,7 @@ class MDConsole {
     final public static function setupCLI():void {
 
         $startTime = microtime(true);
-        register_shutdown_function(function($startTime) {
+        register_shutdown_function(function($startTime):void {
 
             $duration = microtime(true) - $startTime;
 
diff --git a/src/MDOutputHandler.php b/src/MDOutputHandler.php
index 612a8b8..8d0478c 100644
--- a/src/MDOutputHandler.php
+++ b/src/MDOutputHandler.php
@@ -126,7 +126,7 @@ class MDOutputHandler {
             break;
         }
 
-        if (!empty($this->_context)) $contextStr = "{$this->_context} │ ";
+        if ($this->_context !== "") $contextStr = "{$this->_context} │ ";
         else $contextStr = "";
 
         // Generate the message to log.
@@ -136,7 +136,7 @@ class MDOutputHandler {
             file_put_contents($this->_logfile, $message, FILE_APPEND);
         }
 
-        if (($this->_verbosity > 0 && in_array($statusCode, [MDConsole::STATUS_UPDATE, MDConsole::STATUS_DELETION, MDConsole::STATUS_ERROR])) || $this->_verbosity === 2) echo $message;
+        if (($this->_verbosity > 0 && in_array($statusCode, [MDConsole::STATUS_UPDATE, MDConsole::STATUS_DELETION, MDConsole::STATUS_ERROR], true)) || $this->_verbosity === 2) echo $message;
 
         if ($this->_counter % 250 === 0) {
             echo '―――> ' . sprintf("%1$07d", $this->_counter) . " operations processed" . PHP_EOL;