museum-digital/MDAllowedValueSets
32
0 Fork 2
Code Issues 14 Pull Requests Releases Wiki Activity

Allow https links to the library of congress subject headings

Browse Source
This commit is contained in:
jrenslin committed 2023-07-27 01:43:54 +02:00
1 parent 0e86361968
commit f5673c69fd
2 files changed
+7 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/enums/MDNodaRepository.php
+4 -1
View File
@@ -353,7 +353,10 @@ private static function validateLocId(string $id):string|false {
private static function validateLcshId(string $id):string|false {
if (filter_var($id, FILTER_VALIDATE_URL) !== false) {
$id = strtr($id, ['http://id.loc.gov/authorities/names/' => '']);
$id = strtr($id, [
'http://id.loc.gov/authorities/names/' => '',
'https://id.loc.gov/authorities/names/' => '',
]);
}
if (substr($id, 0, 2) !== 'sh') {
tests/MDNodaRepositoryTest.php
+3 -3
View File
@@ -40,9 +40,9 @@ public function testValidIdsValidate():void {
self::assertNotFalse(MDNodaRepository::loc->validateId("n2022014604"));
self::assertNotFalse(MDNodaRepository::loc->validateId("https://id.loc.gov/authorities/names/n2022014604"));
self::assertNotFalse(MDNodaRepository::loc->validateId("http://id.loc.gov/authorities/names/n2022014604"));
self::assertNotFalse(MDNodaRepository::loc->validateId("n2022014604"));
self::assertNotFalse(MDNodaRepository::lcsh->validateId("https://id.loc.gov/authorities/names/sh2022014604"));
self::assertNotFalse(MDNodaRepository::lcsh->validateId("http://id.loc.gov/authorities/names/sh2022014604"));
self::assertNotFalse(MDNodaRepository::lcsh->validateId("sh2022014604"));
}
}