From ae1d37f050c5f3201e4b53dca3faad3eb9e61bde Mon Sep 17 00:00:00 2001 From: Joshua Ramon Enslin Date: Fri, 12 Dec 2025 13:49:07 +0100 Subject: [PATCH] Accept http:// mindat links --- src/enums/MDNodaRepository.php | 2 +- tests/MDNodaRepositoryTest.php | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/enums/MDNodaRepository.php b/src/enums/MDNodaRepository.php index d558646..ae2b096 100644 --- a/src/enums/MDNodaRepository.php +++ b/src/enums/MDNodaRepository.php @@ -734,7 +734,7 @@ enum MDNodaRepository implements MDValueEnumInterface, JsonSerializable { self::klbb => self::validateNumericId($id, ['https://www.kl-bb.de/artist/', 'https://www.kl-bb.de/?page=actor&subPage=']), self::lcsh => self::validateLcshId($id), self::loc => self::validateLocId($id), - self::mindatorg => self::validateNumericId($id, ['https://www.mindat.org/min-', '.html']), + self::mindatorg => self::validateNumericId($id, ['http://www.mindat.org/min-', 'https://www.mindat.org/min-', '.html']), self::moebeltypologie => self::validateNumericId($id, ['https://term.museum-digital.de/moebel/tag/']), self::ndb_adb => self::validateGndId($id, ['https://www.deutsche-biographie.de/pnd', 'https://www.deutsche-biographie.de/gnd', '.html', '#adbcontent', '#ndbcontent', '#indexcontent']), self::ndl => self::validateNumericId($id, [ diff --git a/tests/MDNodaRepositoryTest.php b/tests/MDNodaRepositoryTest.php index 54489f2..b87a8ca 100644 --- a/tests/MDNodaRepositoryTest.php +++ b/tests/MDNodaRepositoryTest.php @@ -87,6 +87,11 @@ final class MDNodaRepositoryTest extends TestCase { self::assertEquals(false, MDNodaRepository::col->validateId("123123")); self::assertEquals("C46V", MDNodaRepository::col->validateId("https://www.catalogueoflife.org/data/taxon/C46V")); self::assertEquals("CRLT8", MDNodaRepository::col->validateId("https://www.catalogueoflife.org/data/taxon/CRLT8")); + self::assertEquals("CRLT8", MDNodaRepository::col->validateId("http://www.catalogueoflife.org/data/taxon/CRLT8")); + + self::assertEquals(false, MDNodaRepository::mindatorg->validateId("adfdasjfklasjl")); + self::assertEquals("2047", MDNodaRepository::mindatorg->validateId("https://www.mindat.org/min-2047.html")); + self::assertEquals("2047", MDNodaRepository::mindatorg->validateId("http://www.mindat.org/min-2047.html")); } }